Skip to content

ref: Convert SentryANRTracker to class #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

ref: Convert SentryANRTracker to class #6465

merged 1 commit into from
Oct 20, 2025

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 20, 2025 •
edited by github-actions bot
Loading

I pulled this change out of the overall dependency container Swift refactor to make that PR easier to review

#skip-changelog

Closes #6466

@github-actions github-actions bot mentioned this pull request Oct 20, 2025
Closed
@noahsmartin noahsmartin force-pushed the sentryANRTrackerRefactor branch from dbd13ab to 0a314aa Compare October 20, 2025 19:08
@codecov Codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 62.26415% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.478%. Comparing base (3319d58) to head (974c0f1).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryANRTrackerV2.m 0.000% 8 Missing ⚠️
Sources/Sentry/SentryANRTrackerV1.m 0.000% 7 Missing ⚠️
Sources/Sentry/SentryDelayedFramesTracker.m 0.000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6465       +/-   ##
=============================================
+ Coverage   86.926%   87.478%   +0.552%     
=============================================
  Files          450       452        +2     
  Lines        37619     37784      +165     
  Branches     17378     17489      +111     
=============================================
+ Hits         32701     33053      +352     
+ Misses        4876      4686      -190     
- Partials        42        45        +3
Files with missing lines Coverage Δ
...urces/Sentry/Profiling/SentryContinuousProfiler.mm 89.726% <100.000%> (ø)
Sources/Sentry/Profiling/SentryProfilerState.mm 99.350% <100.000%> (ø)
Sources/Sentry/Profiling/SentryTraceProfiler.mm 95.384% <100.000%> (ø)
Sources/Sentry/SentryANRTrackingIntegration.m 97.041% <ø> (ø)
...s/Sentry/SentryAutoBreadcrumbTrackingIntegration.m 100.000% <ø> (ø)
Sources/Sentry/SentryCoreDataTrackingIntegration.m 100.000% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.416% <100.000%> (+0.162%) ⬆️
...rces/Sentry/SentryDependencyContainerSwiftHelper.m 92.307% <100.000%> (+0.641%) ⬆️
Sources/Sentry/SentryProfiler.mm 91.011% <100.000%> (ø)
...try/SentryWatchdogTerminationTrackingIntegration.m 85.714% <ø> (ø)
... and 4 more

... and 27 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3319d58...974c0f1. Read the comment docs.

itaybre
itaybre reviewed Oct 20, 2025
View reviewed changes
itaybre
itaybre reviewed Oct 20, 2025
View reviewed changes
itaybre
itaybre approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the sentryANRTrackerRefactor branch 2 times, most recently from 93acb75 to ca65ebb Compare October 20, 2025 20:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.33 ms 1251.12 ms 31.79 ms
Size 23.75 KiB 1022.04 KiB 998.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7123d8e 1222.27 ms 1262.02 ms 39.76 ms
5258fb8 1207.92 ms 1234.51 ms 26.59 ms
07d7e83 1211.71 ms 1240.08 ms 28.37 ms
be882e4 1199.35 ms 1231.20 ms 31.86 ms
4e3915a 1230.02 ms 1258.90 ms 28.88 ms
7273bf4 1202.42 ms 1227.62 ms 25.21 ms
7bd90de 1233.48 ms 1249.47 ms 15.99 ms
f4f94f5 1216.24 ms 1247.94 ms 31.70 ms
7416ffc 1225.55 ms 1241.80 ms 16.25 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms

App size

Revision Plain With Sentry Diff
7123d8e 23.75 KiB 986.80 KiB 963.05 KiB
5258fb8 23.75 KiB 874.45 KiB 850.70 KiB
07d7e83 23.75 KiB 913.27 KiB 889.52 KiB
be882e4 23.75 KiB 946.69 KiB 922.94 KiB
4e3915a 23.75 KiB 858.69 KiB 834.94 KiB
7273bf4 23.75 KiB 908.01 KiB 884.26 KiB
7bd90de 23.75 KiB 933.33 KiB 909.58 KiB
f4f94f5 23.75 KiB 988.02 KiB 964.27 KiB
7416ffc 23.75 KiB 913.63 KiB 889.88 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB

Previous results on branch: sentryANRTrackerRefactor

Startup times

Revision Plain With Sentry Diff
b7237b1 1235.94 ms 1266.00 ms 30.06 ms

App size

Revision Plain With Sentry Diff
b7237b1 23.75 KiB 1022.03 KiB 998.28 KiB

@noahsmartin noahsmartin force-pushed the sentryANRTrackerRefactor branch from ca65ebb to 801a026 Compare October 20, 2025 21:25
@noahsmartin noahsmartin force-pushed the sentryANRTrackerRefactor branch from 801a026 to 974c0f1 Compare October 20, 2025 21:45
@noahsmartin noahsmartin merged commit 9c75c11 into main Oct 20, 2025
192 of 197 checks passed
@noahsmartin noahsmartin deleted the sentryANRTrackerRefactor branch October 20, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itaybre itaybre itaybre approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ref: Convert SentryANRTracker to class

2 participants

@noahsmartin @itaybre